Trim whitespace in forwarded host parsing#7291
Open
raashish1601 wants to merge 1 commit into
Open
Conversation
Ap-0007
reviewed
Jun 7, 2026
Ap-0007
left a comment
Ap-0007
left a comment
There was a problem hiding this comment.
Looks solid! Changing trimRight() to trim() in the comma-separated case ensures we handle leading whitespace from poorly formatted headers, and falling back to trim() for the single value case provides excellent robustness. The added regression tests look very clear as well. Great work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
req.hostto consistently trim whitespace from X-Forwarded-Host when trust proxy is enabled.Changes
lib/request.js: trimX-Forwarded-Hostin both comma-separated and single-value cases.test/req.host.js: add regression test for spaced host header.Validation
npm test -- test/req.host.jsnpx mocha --require test/support/env test/req.host.js